src/components/mui/formik-inputs/mui-formik-radio-group.js (1)

13-19: LGTM! Clean addition of configurable margin prop.

The implementation correctly adds an optional margin prop with a sensible default, preserving backward compatibility while enabling layout customization. This aligns with the PR-wide pattern of exposing more customization options on Formik inputs.

Optional: Consider using PropTypes.oneOf to restrict values to MUI's valid options:

-  margin: PropTypes.string,
+  margin: PropTypes.oneOf(["none", "dense", "normal"]),

Also applies to: 25-25, 65-65

src/actions/page-template-actions.js (1)

145-160: Consider adding null-safety for the modules array.

The normalizeEntity function assumes entity.modules is always a valid array. If entity.modules is null or undefined, the .map() call will throw a runtime error.

Suggested defensive check

 const normalizeEntity = (entity) => {
   const normalizedEntity = { ...entity };

-  normalizedEntity.modules = entity.modules.map((module) => {
+  normalizedEntity.modules = (entity.modules || []).map((module) => {
     const normalizedModule = { ...module };

     if (module.kind === PAGES_MODULE_KINDS.MEDIA && module.upload_deadline) {
       normalizedModule.upload_deadline = moment(module.upload_deadline).unix();
     }
     delete normalizedModule._tempId;

     return normalizedModule;
   });

   return normalizedEntity;
 };

src/pages/sponsors/sponsor-pages-list-page/components/global-page/select-pages-dialog.js (3)

140-143: Hardcoded text should use i18n translation.

The text "items selected" is hardcoded in English. For consistency with the rest of the component, this should use T.translate().

Suggested fix

           <Grid2 size={4} sx={{ mt: 1 }}>
-            {selectedRows.length} items selected
+            {T.translate("sponsor_pages.global_page_popup.items_selected", { count: selectedRows.length })}
           </Grid2>

---

180-183: Consider adding PropTypes for Redux-injected props.

The component receives several props from Redux (pageTemplates, items, currentPage, term, order, orderDir, total, getPageTemplates) but only onClose and onSave are declared in PropTypes. Adding PropTypes for all props improves documentation and development-time validation.

---

38-40: Add getPageTemplates to useEffect dependency array.

The effect references getPageTemplates but the dependency array is empty. While this works because the function reference is stable (from Redux), adding it satisfies the exhaustive-deps rule and makes the intent clearer.

Suggested fix

   useEffect(() => {
     getPageTemplates("", 1, DEFAULT_PER_PAGE, "id", 1, true);
-  }, []);
+  }, [getPageTemplates]);

src/components/mui/formik-inputs/mui-formik-upload.js (1)

125-128: Missing id in PropTypes.

The id prop is used (line 109) but not declared in PropTypes.

Suggested fix

 MuiFormikUpload.propTypes = {
+  id: PropTypes.string,
   name: PropTypes.string.isRequired,
   singleFile: PropTypes.bool
 };

src/actions/sponsor-pages-actions.js (1)

133-133: Silent catch block may hide errors.

The empty catch block swallows all errors silently. While the comment explains the intent to catch promise rejections, consider at minimum logging the error for debugging purposes.

Suggested fix

-      .catch(() => {}); // need to catch promise reject
+      .catch((err) => {
+        console.error("cloneGlobalPage failed:", err);
+      });

src/pages/sponsors/sponsor-pages-list-page/components/global-page/global-page-popup.js (1)

46-49: Consider adding cloneGlobalPage to PropTypes.

The cloneGlobalPage prop is injected by connect but not declared in PropTypes. While optional, documenting injected props improves maintainability.

Proposed fix

 GlobalPagePopup.propTypes = {
   open: PropTypes.bool.isRequired,
-  onClose: PropTypes.func.isRequired
+  onClose: PropTypes.func.isRequired,
+  cloneGlobalPage: PropTypes.func.isRequired
 };

src/pages/sponsors-global/page-templates/page-template-popup.js (1)

160-162: Remove unnecessary formik prop from PageModules.

The PageModules component uses useFormikContext() internally to access formik state (as seen in the relevant code snippet). The formik prop passed here is unused.

Proposed fix

             <Box sx={{ py: 2 }}>
-              <PageModules formik={formik} />
+              <PageModules />
             </Box>

src/pages/sponsors-global/page-templates/page-template-module-form.test.js (2)

64-64: Minor: Comment in Spanish should be in English for consistency.

The comment "Mock DragAndDropList que captura onReorder" should be in English to maintain consistency with the rest of the codebase.

Suggested fix

-// Mock DragAndDropList que captura onReorder
+// Mock DragAndDropList that captures onReorder

---

303-316: Consider: Tests rely on MUI implementation details.

Tests use .closest(".MuiAccordionSummary-root") which couples them to MUI's class naming. This could break if MUI changes its class names in a future version. Consider adding data-testid attributes to the AccordionSummary components in the actual implementation for more resilient testing.

src/pages/sponsors/sponsor-pages-list-page/index.js (3)

45-47: Missing dependency in useEffect.

The useEffect hook uses getSponsorPages but doesn't include it in the dependency array. While this works because getSponsorPages is a stable reference from Redux, ESLint's react-hooks/exhaustive-deps rule would flag this.

Suggested fix

   useEffect(() => {
     getSponsorPages();
-  }, []);
+  }, [getSponsorPages]);

---

63-71: Stubbed handlers with console.log statements.

handleRowDelete and handleArchiveItem contain console.log statements and commented-out code. These appear to be work-in-progress placeholders. Consider adding TODO comments or removing the console.log before merging.

Suggested change

   const handleRowDelete = (itemId) => {
-    console.log("DELETE ITEM ID...", itemId);
-    // deleteSponsorForm(itemId);
+    // TODO: Implement delete functionality
+    // deleteSponsorPage(itemId);
   };

-  const handleArchiveItem = (item) => console.log("archive ITEM...", item);
-  // item.is_archived
-  //   ? unarchiveSponsorForm(item.id)
-  //   : archiveSponsorForm(item.id);
+  const handleArchiveItem = (item) => {
+    // TODO: Implement archive functionality
+    // item.is_archived ? unarchiveSponsorPage(item.id) : archiveSponsorPage(item.id);
+  };

---

205-212: Commented code for FormPagePopup.

The FormPagePopup component is commented out, indicating incomplete functionality. Consider adding a TODO comment to track this work item.

src/i18n/en.json (1)

2644-2658: Minor: Inconsistent casing in translation value.

Line 2648 has "name": "name" (lowercase) while the corresponding column header on line 2632 has "name_column_label": "Name" (capitalized). The popup's name field label should likely be capitalized for consistency.

Suggested fix

     "global_page_popup": {
       "title": "Add Page Template",
       "items_selected": "items selected",
       "code": "Code",
-      "name": "name",
+      "name": "Name",
       "info_mod": "Info Mod",

Configuration used: defaults

Review profile: CHILL

Plan: Pro

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}